Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken image scoring #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidStirling
Copy link
Member

Fixes #327

Looks like something went wrong when implementing 3D mode, and the resulting coordinates list to draw onto images was being clipped to the first two elements.

GetObjectsCoords should only ever return 2D coordinates for objects as they're being mapped onto images. It appears that an attempt was made to have it return 3D, but this was only applied to the query portion rather than the downstream data processing. The attempt to round the third coordinate also doesn't appear to work as intended, though this isn't necessary anyway.

To resolve this I've stripped that part of the function out. If 3D mode does need to show position in 3D then feel free to restore, though I can't see anything trying this in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Score Image" only displays results for the first few objects
1 participant