Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lasso tool work on other plots #305

Open
bethac07 opened this issue Jul 13, 2021 · 2 comments
Open

Make lasso tool work on other plots #305

bethac07 opened this issue Jul 13, 2021 · 2 comments

Comments

@bethac07
Copy link
Member

I recall that that there is a technical reason why it currently is only supported on the dimensionality reduction plot but could not find in 5-10 minutes searching here plus Slack what that reason is. Let's document that here for future potential improvers :)

@DavidStirling
Copy link
Member

The main reason is that the other tools all use a custom navigation toolbar which we reconstructed to look like MatPlotLib's, since there used to be a bug breaking the native wx toolbar. Getting Lasso support will require us to replace that messy toolbar code with the newer solution, plus a rewrite of the (largely unused) 'selection' feature in those tools.

I think it only really makes sense to enable Lasso in the Scatter tool, so it's not a huge amount of work, but we wanted to see whether people found it useful before doing such a rewrite.

@vladimirvig
Copy link

I would definitely find this useful because the current selection option (filter+gate) pulls out all the cells that are not on the plot (thereby ignoring the filter setting) in addition to the target ones. (I created an issue for that, too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants