Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QT Celestial Browser sorting #7

Closed
CelestiaProject opened this issue Feb 3, 2017 · 8 comments
Closed

QT Celestial Browser sorting #7

CelestiaProject opened this issue Feb 3, 2017 · 8 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on

Comments

@CelestiaProject
Copy link
Collaborator

Need to fix a few defects in Celestial Browser (QT):

  1. Solar system. Sort by name and type is not yet implemented.
  2. Stars. Pressing the "name" button to sort by distance, not by name.
  3. Deep Sky Objects. Pressing the "name" button to sort by distance, not by name.
@CelestiaProject CelestiaProject added the bug Something isn't working label Feb 3, 2017
@Alexell
Copy link
Contributor

Alexell commented Mar 19, 2017

qtcelestialbrowser.cpp

@Alexell
Copy link
Contributor

Alexell commented Mar 19, 2017

Function bool StarPredicate
case Alphabetical: return false; // TODO

@CelestiaProject
Copy link
Collaborator Author

We think:

  1. Add the fourth column "Asteroids and comets", and in the column "Solar System" show only the Planets, Dwarf Planets, Moons and Small Moons.
  2. Perhaps for spacecraft need a fifth tab, because with a large number of additions, it would be convenient to see all the spacecraft separately.
  3. We think that you can make the browser more informative and useful. The browser should contain more columns with parameters (Kepler parameters + the rest). The sorting should work for each column.

It is very important to create a quality catalog.

@CelestiaProject
Copy link
Collaborator Author

CelestiaProject commented Apr 19, 2017

In order not to increase the size of the Celestial Browser:
There is a vertical scroll in the catalog table. Just add a horizontal scroll bar in table bottom. Then can not change the size of the browser, and the columns that do not fit the width can be seen by sliding the horizontal scoll.

@CelestiaProject CelestiaProject added the enhancement New feature or request label Apr 19, 2017
@gstark667
Copy link
Contributor

I made a pull request addressing name sorting on some of the tabs: #43
The TreeView is a little more complicated to get sorting, so I might try working on the "Asteroids and comets" and spacecrafts tabs next.

@CelestiaProject
Copy link
Collaborator Author

@gstark31897 Thank you. Later we will check the work of your changes. We will be grateful if you completely solve the sorting problem described in the first message.

@gstark667
Copy link
Contributor

Alright, I'll focus on finishing up the solar system sorting then. Thanks.

@CelestiaProject CelestiaProject deleted a comment from amirabbaska Nov 20, 2018
@375gnu 375gnu added this to In progress in Release 1.7.0 Dec 1, 2018
@375gnu
Copy link
Member

375gnu commented Dec 4, 2018

Hi @pirogronian , i suppose we can close this issue. The more I think the close I am to the conclusion that we don't need name/type sorting for the Solar System Browser.

  1. It's initial sorting order is by distance from a parent (star, planet, etc). So we need an additional control to restore original sort order.
  2. Sorting by type is useless as we have grouping. I also have some WIP filtering code.
  3. Sorting by name should help to look up for required object. But for me it's better to add a search box instead.

@375gnu 375gnu added the help wanted Extra attention is needed label Mar 22, 2019
@375gnu 375gnu moved this from In progress to To do in Release 1.7.0 Oct 31, 2019
SevenSpheres pushed a commit to SevenSpheres/Celestia that referenced this issue Apr 9, 2020
To be more up-to-date with the official code
@375gnu 375gnu closed this as completed Jul 23, 2020
@375gnu 375gnu added the won't fix This will not be worked on label Jul 23, 2020
@levinli303 levinli303 removed this from To do in Release 1.7.0 Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants