Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build instructions #534

Closed
shujaatak opened this issue Nov 26, 2019 · 9 comments
Closed

Build instructions #534

shujaatak opened this issue Nov 26, 2019 · 9 comments
Labels
question Further information is requested

Comments

@shujaatak
Copy link

Where can I find build instructions for Windows?
Is there any step by step guide/tutorial?
In most Github repositories I find the build instructions/links in the Readme file or in Wiki but I couldn't find them in Celestia repository.

@shujaatak
Copy link
Author

shujaatak commented Nov 26, 2019

Clear and easy build instructions/method would attract more developers to contribute to Celestia.
Most successful and growing projects are usually those that are not only user friendly but also developer friendly.

@levinli303
Copy link
Collaborator

yes I agree. Currently you can resort to the INSTALLATION file in the root directory for building.

We will need to rewrite that file in markdown to make it more friendly

@375gnu
Copy link
Member

375gnu commented Nov 26, 2019

Please refer to https://github.com/CelestiaProject/Celestia/blob/master/INSTALL, both MSVC and GCC (Mingw) are supported.

@375gnu 375gnu added the question Further information is requested label Nov 26, 2019
@shujaatak
Copy link
Author

IMHO build method described here https://github.com/CelestiaProject/Celestia/blob/master/INSTALL is so complex and time consuming that some developers wouldn't even think to try to build the Celestia by themselves leave aside contributing. This method is so discouraging.
IMHO all ThirdParty libs should be integrated in Celestia repository which could be downloaded using git clone --recursive https://github.com/CelestiaProject/Celestia.git or directly using git clone https://github.com/CelestiaProject/Celestia.git. This way the developer would only need to build and run the project that's it. At least core project should be easy to build and run. The optional packages can be allowed to be configured through vcpkg.

@375gnu
Copy link
Member

375gnu commented Nov 26, 2019

I would like to see how you integrate GNU gettext, without official support for MSVC and CMake, GLEW (autogenerated, so it requires 2 stage build), lua and libpng. I also would like to see how you recompile Qt every time you change the main CMakeList.txt or pass another option to CMake.

popcorn

@larsnaesbye
Copy link
Contributor

Let's gradually make the build instructions better so we can get even more contributors!
I've started softly with #573 ...

@larsnaesbye
Copy link
Contributor

@eyvallah : Would you like me to rewrite it in Markdown?

@levinli303
Copy link
Collaborator

@eyvallah : Would you like me to rewrite it in Markdown?

That would be great, go ahead

@larsnaesbye
Copy link
Contributor

@eyvallah : Here you go -> #579

Could probably use some linting and extra line breaks, but it's a start :-)

@375gnu 375gnu closed this as completed Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants