Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Send to self is breaking other Extension #97

Open
Aergernis opened this issue Oct 4, 2023 · 3 comments
Open

Bug Report: Send to self is breaking other Extension #97

Aergernis opened this issue Oct 4, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Aergernis
Copy link

Describe your problem in one sentence:
Selecting "remove send to self" is breaking https://github.com/xuejianxianzun/PixivFanboxDownloader on Edge

Name the affected patch/problem (if available)
Remove send to self

Your used browser
Edge: 117.0.2045.36 64-Bit

Longer description (optional)
When installing Patches and Remove send to self is selected, it breaks PixivFanboxDownloader when using Edge. The extension is not downloding files anymore after last Egde update.

Additional information (optional)
xuejianxianzun/PixivFanboxDownloader#52

@Aergernis Aergernis added the bug Something isn't working label Oct 4, 2023
@Aergernis Aergernis changed the title Bug Report: Bug Report: Send to self is breaking other Extension Oct 4, 2023
@Ceiridge
Copy link
Owner

Ceiridge commented Oct 4, 2023

Remove Send To Self is a patch only meant for Chrome, as it can be seen in the tooltip description of the patch.
It is recommended to only patch what is needed.
Have you also tried uninstalling the patcher and then check if the downloads are working again?

@Aergernis
Copy link
Author

Aergernis commented Oct 5, 2023

Have you also tried uninstalling the patcher and then check if the downloads are working again?

Yes and it's working without

Remove Send To Self is a patch only meant for Chrome, as it can be seen in the tooltip description of the patch. It is recommended to only patch what is needed

So i have to patch Edge and Chrome in two steps when both are installed? I thought, when "Chrome only" the patcher would not apply anything to Edge.

@Ceiridge
Copy link
Owner

So i have to patch Edge and Chrome in two steps when both are installed? I thought, when "Chrome only" the patcher would not apply anything to Edge.

No, the installed patcher runs for all selected browsers.
Chrome only means that it only works for Chrome. Running the patcher with such a patch on other browsers can cause undefined behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants