Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 1 more extension warning #85

Open
oleedd1 opened this issue Nov 22, 2022 · 12 comments
Open

Removing 1 more extension warning #85

oleedd1 opened this issue Nov 22, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@oleedd1
Copy link

oleedd1 commented Nov 22, 2022

Please make possible enabling extensions not from the store.
image
The toggle is blocked.

@oleedd1 oleedd1 added the enhancement New feature or request label Nov 22, 2022
@oleedd1 oleedd1 changed the title Removing 1 more warning Removing 1 more extension warning Nov 22, 2022
@Ceiridge
Copy link
Owner

Maybe you can extract the extension file to a folder (it is a zip file with a different extension) and then you can load the extension folder in chrome://extensions after activating the developer settings. This should not cause a warning

@oleedd1
Copy link
Author

oleedd1 commented Nov 24, 2022

Yes, but better to remove this warning too. Usual installing is much more convenient. Please.

@Ceiridge
Copy link
Owner

I will maybe look into it in the next days

@oleedd1
Copy link
Author

oleedd1 commented Nov 25, 2022

It uses verified_contents.json for validation and it is done offline. Non-store extensions don't have this file.

@Ceiridge
Copy link
Owner

I don't think I will want to fix this. I don't want this patcher to have potential to be abused to install automatically install extensions without knowledge, which is often done by annoying antiviruses for example with their CRX file. It should be sufficient for normal use cases to just use the extracted folder?

@Ceiridge
Copy link
Owner

@oleedd1
Copy link
Author

oleedd1 commented Nov 27, 2022

But Chromium allows to install any extensions (at least allowed).
And Chrome shows an alert when you try to install, for example:
image
And installing from url is already disabled, as I see.
Antiviruses etc. use store extensions. And it doesn't stop them to install automatically.
Anyway, it's enough for me if you just tell how to fix this in assembler.

@Ceiridge
Copy link
Owner

It's not too easy to patch this, mostly because helpful functions, such as ShouldEnforce have been removed during compilation because of optimization. I think it's too much effort for something that isn't especially useful.
If you want to take a look at it yourself, I recommend debugging the main Chrome process with x64dbg, looking at the chrome.dll symbol (make sure to loadsym the pdb debug symbol file of chrome.dll, which can be downloaded here with symchk for instance: https://chromium-browser-symsrv.commondatastorage.googleapis.com/ )

@oleedd1
Copy link
Author

oleedd1 commented Nov 28, 2022

It is very important and useful because "Developer mode" is for developers while usual installing is for all users. Usual people don't search about the developer mode and will not find this. And Chrome uses another saving algorithm for extensions from folders, no folders created for them, so it is not the same. There may be other differences.
But the last version of Chromium doesn't show this warning, all extensions work there, I have just checked this. How can the Chromium source code help?

@Ceiridge
Copy link
Owner

I don't really see a reason to add this.

@oleedd1
Copy link
Author

oleedd1 commented Nov 28, 2022

Then warning removing will be ultimate. For now, you remove 1 but leave the 2-nd. So patching is not complete. More users will find this pather. It is a Chrome limitation to annoy users and force them to expend the store. Please.

@Ceiridge
Copy link
Owner

I will definitely keep this mind and will possibly look further into this issue in 1-2 business decades. In the meantime I can recommend extracting the extension first and then loading the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants