Fix sanchonet sync tip #168
Conversation
|
Nice @klarkc. Note that I think 8.9.0 is an easy reach. I've recently integrated that one on Ogmios and apart from some changes in the local state query protocol (which Kupo doesn't use), there wasn't much. So ideally, we can just bump to that one directly. |
|
@KtorZ, it seems we've reached the sancho tip (slot 25834774 at the moment). I'll return to this to bump cardano-node if I encounter any blocking issues here. I couldn't get the CI test to pass. It appears there is a mismatch between the repository source files and the tested source files (maybe due to some weird caching behavior?). |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
| <|> | ||
| -- TODO: This is probably redundant (now with decodeAddr and/or decodeAddrLenient |
There was a problem hiding this comment.
We must use decodeAddrLenient here. decodeAddr is just broken and doesn't work on historical data :)
| -- TODO Remove unneeded unsafe upgrade from AlonzoEra to ConwayEra | ||
| -- I could not find any evidence that we should upgrade | ||
| -- from AlonzoEra to ConwayEra but to avoid introducing | ||
| -- breaking changes I'm keeping current design through | ||
| -- this unsafe function |
There was a problem hiding this comment.
ConwayEra's script are a superset of AlonzoEra's scripts, like most types on the ledger; which is why Kupo has this approach of "upgrading" data into the most recent type. There's nothing unsafe about it in principle.
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Fix #164