Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience with connectivity issues #221

Open
Betree opened this issue Mar 2, 2023 · 0 comments
Open

Improve resilience with connectivity issues #221

Betree opened this issue Mar 2, 2023 · 0 comments
Labels
complexity > medium Consequent tasks, usually done in one to three days of work frontend Everything for https://github.com/CaptainFact/captain-fact-frontend improvement Improvements to existing features (enhancements)

Comments

@Betree
Copy link
Member

Betree commented Mar 2, 2023

We had various reports of disconnect not being appropriately handled, which can produce different results:

  • The person tries to add a comment; it is effectively added but never appears in the interface
  • We show a random "disconnected" message, and it's unclear whether we missed any API event. This likely happens after putting the tab in the background for a few minutes.

To reproduce:

  • Open a video
  • Set yourself as "Offline" in the network settings
  • Re-connect
  • Try to post a comment

Expected:

  • Users should be reconnected to the channel
  • We should fully re-synchronize the state in case we missed any event
  • All form states should be preserved (do not erase pending comments)
  • We can eventually show a loading status with all fields disabled while reconnecting
  • Once reconnected, a "Success - Reconnected" toast should pop up
@Betree Betree added improvement Improvements to existing features (enhancements) frontend Everything for https://github.com/CaptainFact/captain-fact-frontend complexity > medium Consequent tasks, usually done in one to three days of work labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity > medium Consequent tasks, usually done in one to three days of work frontend Everything for https://github.com/CaptainFact/captain-fact-frontend improvement Improvements to existing features (enhancements)
Projects
None yet
Development

No branches or pull requests

1 participant