Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User specified id on combobox list item causes infinite loop #76

Open
codewithcheese opened this issue Oct 28, 2023 · 1 comment
Open

Comments

@codewithcheese
Copy link

codewithcheese commented Oct 28, 2023

Hi, loving the concept and implementation of this library, being able to bring your own HTML and then adding actions to get the required functionality feels like a real solution for headless UI logic finally. Thank you!

I encountered an infinite state update loop due to an id being set on the combobox list item. Here's what I mean codewithcheese@d7ff662

I was copying some HTML from tailwindui which had ids set. I see this breaks how the library uses ids internally, and I now know to remove them.

This was hard to debug and not a pleasant DX. If the goal is for users to bring actions to their own HTML then this could be a common pitfall. Not sure of the solution, maybe even just a warning would help

@CaptainCodeman
Copy link
Owner

It would probably make sense to just keep any existing ID if there was one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants