Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close out the login form once the user has logged in #22

Open
upkarlidder opened this issue Aug 6, 2021 · 10 comments
Open

Close out the login form once the user has logged in #22

upkarlidder opened this issue Aug 6, 2021 · 10 comments

Comments

@upkarlidder
Copy link
Member

Is your feature request related to a problem? Please describe.
The extension should close out the login form once the user has logged in. The user could also be given a possibility to log out.

Related to #16

image

Describe the solution you'd like
Replace the login form with a logout button once the user has been authenticated.

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 6, 2021
@josiemundi josiemundi added good first issue Good for newcomers and removed stale labels Sep 16, 2021
@akshaymattoo
Copy link

@upkarlidder I would like to take this issue.

@upkarlidder
Copy link
Member Author

Sounds good @akshaymattoo. Just confirming with @josiemundi and @sebastiaanzaaijer as I know they were also working on the extension. Thank you!

FYI @demilolu

@akshaymattoo
Copy link

@upkarlidder Am I good to start on this issue?

@sebastiaanzaaijer
Copy link
Contributor

Hi @akshaymattoo, yeah that would be great thanks!

@akshaymattoo
Copy link

akshaymattoo commented Oct 25, 2021

@sebastiaanzaaijer I have made the changes and tested them as well in my local. It works fine. I have a question I am not able to make another branch out of main to generate a pull request. Can you please direct me in that direction on how do I raise a pull request?
On the other topic, I would like to make some modifications to the Readme where I would like to add more details. Shall I create an issue for that first and then you can review and let me know if you would like to proceed with that?

@upkarlidder
Copy link
Member Author

Hello @akshaymattoo, pls create a fork first and then you should be able to push to your fork and create a PR from there. Let us know if that does not work. Thank you again for your contribution!

@akshaymattoo
Copy link

@upkarlidder I did open the pull request. Thank you for the direction.

@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 25, 2021
@github-actions github-actions bot closed this as completed Dec 9, 2021
@demilolu demilolu reopened this Feb 3, 2022
@demilolu demilolu removed the stale label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed in 14 days.

@github-actions github-actions bot added the stale label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants