Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky steps should not run in Github actions #306

Closed
davidnixon opened this issue Nov 24, 2021 · 3 comments
Closed

Husky steps should not run in Github actions #306

davidnixon opened this issue Nov 24, 2021 · 3 comments
Labels
bug Something isn't working CI/CD stale

Comments

@davidnixon
Copy link
Member

Describe the bug
The Husky postinstall should not run in the it the Github deployment actions.

To Reproduce
Dev dependencies are not avail in the deployment actions so trying to run any of them fail

Expected behavior
Husky postinstall should be based on the CI environment variable. If CI is true the post install should not run.

Additional context
See failed pipeline results in IBM cloud.
Temporarily we use a sed command like this to disable postinstall

sed -i  's/"postinstall":.*$/"postinstall": "",/g' package.json
@davidnixon davidnixon added bug Something isn't working CI/CD labels Nov 24, 2021
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Dec 25, 2021
@davidnixon
Copy link
Member Author

Not stale

Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD stale
Projects
None yet
Development

No branches or pull requests

2 participants