Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text doesn't appear on Android app #291

Closed
cstefano1 opened this issue Oct 28, 2021 · 4 comments
Closed

Text doesn't appear on Android app #291

cstefano1 opened this issue Oct 28, 2021 · 4 comments
Assignees
Labels
bug Something isn't working Mobile pwa stale

Comments

@cstefano1
Copy link
Member

cstefano1 commented Oct 28, 2021

Describe the bug
The text "5/5 equals a whole. A whole person…" doesn’t appear on the mobile app

To Reproduce
Steps to reproduce the behavior:

  1. Go to mobile app
  2. Notice missing text

Expected behavior
I presume the text should be there.

Screenshots
Screenshot of web app:
image
Screenshot of mobile app:
image

Smartphone (please complete the following information):

  • Device: Samsung S10+
  • OS: Android
  • Browser: N/A (on mobile app)
  • Version 11

Additional context
Add any other context about the problem here.

@cstefano1 cstefano1 added bug Something isn't working Mobile pwa labels Oct 28, 2021
@upkarlidder
Copy link
Member

Thank you @cstefano1 for creating this issue. I had not noticed. Anything under 1056px, the text is taken out as the display is set to none. I am guessing this was a design decision taken when the code was written. @davidnixon @sebastianhuynh-nyc probably know more.

.hero__description {
  @include carbon--type-style('productive-heading-03');
  display: none;
  max-width: 630px;
  margin-bottom: $spacing-06;

  @media (min-width: 1056px) {
    display: block;
  }
}

@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@cstefano1
Copy link
Member Author

Closed by bot; I'm reopening.

@cstefano1 cstefano1 reopened this Jan 10, 2022
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mobile pwa stale
Projects
None yet
Development

No branches or pull requests

4 participants