Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub action to test new code before merging #232

Closed
10 tasks
upkarlidder opened this issue Sep 23, 2021 · 5 comments
Closed
10 tasks

Create GitHub action to test new code before merging #232

upkarlidder opened this issue Sep 23, 2021 · 5 comments

Comments

@upkarlidder
Copy link
Member

upkarlidder commented Sep 23, 2021

Background on the problem the feature will solve/improved user experience

Add GitHub Actions to test and build new code pushed to a branch or committed to a pull request. Code that passes all the steps in the GitHub action can be merged in the repository.

Describe the solution you'd like

A GitHub action runs whenever code is committed to any branch or PR is made to the main branch.

  • services folder

Refer to a similar action that was implemented for the UI folder.

Each action will

  • install dependencies (yarn install)
  • build for production (yarn build)
  • run all tests (yarn run test:unit)
  • linting with prettier (yarn run lint)

Tasks

Acceptance Criteria

GitHub action runs for every new code commit and PR.

FYI @demilolu @davidnixon

@gibrankasif
Copy link
Contributor

Could I take this task?

@upkarlidder
Copy link
Member Author

Go for it @gibrankasif!

FYI @demilolu @davidnixon @GeraldMit

@gibrankasif
Copy link
Contributor

Hi @upkarlidder I've linked a PR for this issue.

@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Apr 20, 2024
Five Fifths Voter automation moved this from To do to Done May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants