Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error is shown when visiting an invalid page #218

Closed
upkarlidder opened this issue Sep 20, 2021 · 3 comments
Closed

No error is shown when visiting an invalid page #218

upkarlidder opened this issue Sep 20, 2021 · 3 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed stale

Comments

@upkarlidder
Copy link
Member

Describe the bug
A blank page is shown when you visit an invalid site. http://localhost:3001/#/votersupport12345

To Reproduce
Steps to reproduce the behavior:

  1. Serve the page locally
  2. Go to http://localhost:3001/#/votersupport12345
  3. A blank is shown to the user

Expected behavior
I am not sure. @davidnixon @GeraldMit thoughts?

  1. Show the user a custom 404
  2. take the user to the home page

Screenshots
image

This is low priority at this time.

@demilolu @Sabine-Justilien @cstefano1

@upkarlidder upkarlidder added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 20, 2021
@upkarlidder upkarlidder added this to To do in Five Fifths Voter via automation Sep 20, 2021
@ghost ghost mentioned this issue Oct 3, 2021
12 tasks
@github-actions
Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@GeraldMit
Copy link
Member

GeraldMit commented Oct 29, 2021

@upkarlidder @cstefano is this resolved by #258 ? if so can we close this?

If not, can we update to clarify what is left so someone else will pick up?

Copy link

👋 Hi! This issue has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Apr 21, 2024
Five Fifths Voter automation moved this from To do to Done May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed stale
Projects
Development

No branches or pull requests

4 participants