Handling git clonefork errors more gracefully #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cali0707 <calumramurray@gmail.com>
Signed-off-by: Cali0707 <calumramurray@gmail.com>
Cali0707
changed the title
Leo6Leo
requested changes
Jul 18, 2023
Leo6Leo
requested changes
Jul 23, 2023
|
|
||
| if ! git clone $GIT_ORIGIN 2>/dev/null | ||
| then | ||
| echo "Failed to clone the repository. Please use a valid url pointing to your fork" |
There was a problem hiding this comment.
if the repo exists in the current directory, the error message should be different.
Currently.
There was a problem hiding this comment.
@Leo6Leo just clarifying, in this scenario the repo exists in the current directory before running git clonefork <url>, and then you run git clonefork <url>?
Signed-off-by: Cali0707 <calumramurray@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
To handle the errors more gracefully, we need to:
curlerrors silently and provide our own error messagegit cloneerrors silently and provide our own error message