Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Fittings Database addition #47

Open
STAATSY opened this issue Feb 2, 2022 · 7 comments
Open

Feature request: Fittings Database addition #47

STAATSY opened this issue Feb 2, 2022 · 7 comments

Comments

@STAATSY
Copy link

STAATSY commented Feb 2, 2022

Hi Caleb,

It would be good to have similar functionality to the piping schedule database functions you have but for piping fitting dimensions. It would be great to see fitting databases much like Pipedata-Pro (https://www.pipedata.com/10-Software/01-Pipedata-Pro/DataSummary/) implemented in this library so they can be pulled directly into calculations and assessments similar to the "nearest_pipe" function for for dimensions, weights, etc for flanges, elbows, etc.

Context:
First off, amazing work here. I am currently trying testing this on an implementation of MicroPython (through ndless support, not native) on a TI-Nspire CAS CX as I have been looking for a way to run this type of analysis and have a database of piping on my handheld. I haven't done extensive testing but most of the features I have tested so far work on the platform and I am just working on how I can make it useful for myself (ie either need to make myself a front end to do full analysis in MicroPython or find a way to MicroPython to export results to somewhere the calculator can pick up and bring into the rest of my analysis tools already on calc). My model only has aftermarket support for python which is a double-edged sword as it makes it somewhat more versatile than the TI supported implementation on the CXII but it also cuts off direct integration into the main calculator functions.

@CalebBell
Copy link
Owner

Hi,
Do you have a specific fitting in mind? If you identify a specific standard and digitize a table I can see about including the data in Fluids. Otherwise, for a free and open source project provided as is, I think this request is too broad to leave the issue open.
Sincerely,
Caleb

@STAATSY
Copy link
Author

STAATSY commented Feb 2, 2022

Good call... I just wanted to see if you were open to it first... I should have or be able to find some digitised tables and provide them. Leave it with me, I will try return with a more specific request ASAP.

@STAATSY
Copy link
Author

STAATSY commented Feb 2, 2022

The attached is the tables I am interested in having available in this library... I have had a look and spoken to some more experienced guys and they have never seen digitised (Excel / .csv) versions of these tables... but if you are interested and willing to code the integration of these tables into the libraries functionality similar to the piping schedule tables then I can do the manual work of digitising them. I would just need to understand you're desired format and layout so I build them in a way that is easy for you to work with.

onesteel-metalcentre-pipe-and-fittings-data-charts.pdf
https://www.libertygfg.com/media/164103/onesteel-metalcentre-pipe-and-fittings-data-charts.pdf

@Matt-Greer
Copy link

I don't know where one could upload or send fittings tables but I have an Excel workbook with a lot of info in it for flanges, valves, reducers, swages, etc. etc. etc. These types of workbooks get passed around as it's pretty much publicly available.

@STAATSY
Copy link
Author

STAATSY commented Jul 14, 2022 via email

@CalebBell
Copy link
Owner

Hello,

Feel free to send this data to my personal email. I have not take action on this topic because the followup request was too big. If you are looking for a specific fitting, maybe we can start with one fitting; but asking to add all of them is too many. If adding one goes well, we can add another, and so on.

Sincerely,
Caleb

@Matt-Greer
Copy link

Fitting dimensions can be found here: http://hackneyladish.com/DimensionData.aspx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants