Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts don't work / invalid filename doesn't throw an exception / content-name not recognized #124

Open
dreamflasher opened this issue Jan 12, 2023 · 2 comments
Labels
bug A report of or a fix for a bug or unwanted behaviour

Comments

@dreamflasher
Copy link
Contributor

As stated by the documentation downloads should timeout after 30 seconds, which they don't. For me they just never timeout. So I tried to add more timeouts to see if I can get any to work:

dl = Downloader(config=SessionConfig(timeouts=ClientTimeout(total=16, sock_read=16)))

But for this I have the same effect: Some downloads get stuck forever.

@dreamflasher
Copy link
Contributor Author

Maybe I am actually facing a different problem: I try to download this file: https://www.omnycontent.com/d/playlist/e73c998e-6e60-432f-8610-ae210140c5b1/f4e26994-3ddb-4ec7-b855-ae32006cd5de/ea4fae0c-3282-4cfd-b315-ae32006cd5ec/image.jpg?t=1650999093&size=Large and parfive gets stuck.

Because it gets stuck, I thought it's a timeout issue. But maybe the timeout works, but the file writing fails? When I try to download this file with download(filename=image.jpg) it works fine. So it looks like it fails because it tries to write filenames with illegal characters (Windows). That should throw an exception, but also the content-name is image.jpg so somehow that doesn't get recognized?

@dreamflasher dreamflasher changed the title Timeouts don't work Timeouts don't work / invalid filename doesn't throw an exception / content-name not recognized Jan 13, 2023
@Cadair
Copy link
Owner

Cadair commented Mar 28, 2023

Could you try this with debug logging enabled?

@Cadair Cadair added the bug A report of or a fix for a bug or unwanted behaviour label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A report of or a fix for a bug or unwanted behaviour
Projects
None yet
Development

No branches or pull requests

2 participants