Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic retry option #119

Open
dreamflasher opened this issue Jan 10, 2023 · 6 comments
Open

Add automatic retry option #119

dreamflasher opened this issue Jan 10, 2023 · 6 comments
Labels
enhancement A new feature or other enhancement to the library good first issue help wanted

Comments

@dreamflasher
Copy link
Contributor

It would be great if you could add a flag to configure the number of retries in case a download fails.

@Cadair
Copy link
Owner

Cadair commented Jan 14, 2023

Hi 👋

Thanks for the issues, I am on family leave at the moment so I can't promise anything will get addressed quickly.

There is currently only explicit retry support by calling the Downloader.retry method, so you could cook up a wrapper which does this if there are errors on the results object.

@Cadair Cadair changed the title Add retry option Add automatic retry option Jan 14, 2023
@Cadair Cadair added enhancement A new feature or other enhancement to the library help wanted good first issue labels Jan 14, 2023
@dreamflasher
Copy link
Contributor Author

Congratulations and I wish you all a lovely time together! I am glad to hear that you're only temporarily away from the project, and for the best reason :)

So are you in principle open for PRs?

@Cadair
Copy link
Owner

Cadair commented Jan 14, 2023

Thanks!

So are you in principle open for PRs?

I am almost always in favour of PRs, as long as they don't add things which are complex to maintain (which I don't think this would) as I already struggle to find as much time for this project as I would like 😄

@dreamflasher
Copy link
Contributor Author

@Cadair Hope you are enjoying your family time! How long do you currently plan to be on family leave? :)

@Cadair
Copy link
Owner

Cadair commented Mar 28, 2023

Hey, I am back at work at least part time, just been trying to catch up.

I put a comment on #127 is there anything else that needs my attention?! 😀

@dreamflasher
Copy link
Contributor Author

Welcome back! That's fantastic! Let me catch up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or other enhancement to the library good first issue help wanted
Projects
None yet
Development

No branches or pull requests

2 participants