Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3 QA] Graph item presets and saved views seem to be ignored. #5591

Open
sgvfr opened this issue Nov 22, 2023 · 6 comments
Open

[1.3 QA] Graph item presets and saved views seem to be ignored. #5591

sgvfr opened this issue Nov 22, 2023 · 6 comments
Labels
confirmed Bug is confirm by dev team enhancement General tag for an enhancement
Milestone

Comments

@sgvfr
Copy link
Sponsor

sgvfr commented Nov 22, 2023

Describe the bug

Preset Graphs items in the user profile, or using the "save" button seems to be ignored.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Console/Configuration/Users//User Settings'
  2. Change Preview Graphs Per Page to anything other than 10
  3. Go to 'Console/Configuration/Users//General'
  4. Enable 'Maintain Custom Graph and User Settings'

logout,
log back in - View device with more than 10 graphs and only 10 are displayed in tree mode

Go to graph_view.php?action=preview
Select 100 and save.
logout, log back in and return to the preview page.. the saved profile is not used.

image

image

image

Have I simply missed a configuration option somewhere?

@sgvfr sgvfr added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 22, 2023
@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Nov 23, 2023
@TheWitness TheWitness added this to the v1.3.0 milestone Nov 23, 2023
@TheWitness
Copy link
Member

Well, this may be a real issue and likely in 1.2.x too. However, we won't be fixing it there. I'll log it as a non QA bug for now and dig in later.

If you can not save custom settings, it should take the default. If you enable custom settings, it should take either the default or the last thing you saved before it was disabled, or the cached value from the session.

The question becomes, do we wipe the custom settings when an Admin takes away your right to save them. I'm pretty sure that's what we have to do. What do you think?

@TheWitness TheWitness changed the title Graph item presets and saved views seem to be ignored. [1.3 QA] Graph item presets and saved views seem to be ignored. Nov 23, 2023
@sgvfr
Copy link
Sponsor Author

sgvfr commented Nov 24, 2023

well, I guess it depends on what priority you want the custom settings to be, admin is first of course, then is it groups then users?

If a user is a member of a group, and the option to save custom settings is disabled in the group, but enabled for the user, who wins? and the other way around?

My thought would be default settings are always inherited, group settings override defaults, but user settings override groups so some group members of a group have a little more flexibility . but if the admin removes those rights, then defaults always inherit?

@TheWitness
Copy link
Member

Right now, it's strictly a permissive system and there is no precedence. If the user gets it, then user wins by it's nature. I guess that could change. I know that at one point, a user had asked that it be more restrictive and that the admin should be able to define the order. My guess is that they wanted some groups to go last if you were a member. I know many customers who will remove all local permissions and leave it entirely to the group. But right now, there is no way to do that en-mass other than with database calls.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the outdated No recent activity label Jan 24, 2024
@TheWitness TheWitness reopened this Jan 31, 2024
@TheWitness TheWitness removed the outdated No recent activity label Jan 31, 2024
Copy link

github-actions bot commented Apr 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the outdated No recent activity label Apr 1, 2024
@TheWitness TheWitness added enhancement General tag for an enhancement and removed bug Undesired behaviour outdated No recent activity labels Apr 5, 2024
@TheWitness
Copy link
Member

Moved to an enhancement to keep it from closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Bug is confirm by dev team enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants