Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation view animation issue #54

Closed
thisIsTheFoxe opened this issue May 12, 2024 · 3 comments
Closed

Navigation view animation issue #54

thisIsTheFoxe opened this issue May 12, 2024 · 3 comments

Comments

@thisIsTheFoxe
Copy link

thisIsTheFoxe commented May 12, 2024

Describe the bug
When trying to use SkeletonUI in a NavStack it seems to animate the view from the origin.

To Reproduce

import SwiftUI
import SkeletonUI

struct SkeletionAnimationView: View {
    var body: some View {
        NavigationStack {
            Text("")
                .skeleton(with: true)
        }
    }
}

#Preview {
    SkeletionAnimationView()
}

Expected behavior
Same as w/o the NavStack. It should show a fullscreen capsule with the skeleton animation.

Screenshots
https://github.com/CSolanaM/SkeletonUI/assets/18512366/8a5a8e03-eea2-4ce7-8012-79766b7ac997

Smartphone:

  • OS: iOS 17.4.1
  • Version 2.0.1

Additional context
Don't want to assume anything, but possibly an iOS issue:

@thisIsTheFoxe
Copy link
Author

Just saw your comment about using .main queue in #52, using that in the SkeletonModifier seems to fix that issue.

@CSolanaM
Copy link
Owner

CSolanaM commented May 20, 2024

Thanks for that! I was skeptical if this was being reproduced by other people and if what I suggested would work in every case. Looks like I can release a new version with the fix! Thanks @thisIsTheFoxe !

PS: Thanks also for taking your time and providing the radar link.

@CSolanaM
Copy link
Owner

Fixed in 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants