Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy.misc (latest version), typo and type #11

Open
RR5555 opened this issue Sep 4, 2019 · 1 comment
Open

Scipy.misc (latest version), typo and type #11

RR5555 opened this issue Sep 4, 2019 · 1 comment

Comments

@RR5555
Copy link

RR5555 commented Sep 4, 2019

Disclaimer: I did not go through all the code yet, plus not familiar with thread manipulation and such in python, and I did not run the code yet (some compatibility mishaps to correct with scipy.misc for imresize in the latest version of the libs and checking the code including the file manipulation still hold me from doing so).

Changed:

from PIL import Image
# mask = imresize(feature_map, (concept_map['sh'], concept_map['sw']), mode='F')
mask = np.array(Image.fromarray(feature_map).resize((concept_map['sh'], concept_map['sw'])))

(Did not run that version, so maybe it is breaking the code or buggy)

There seems to be a typo in that line:

self.poool.cancel_join_thread()

Then, without any understanding of the underlying program but with pylint, not sure if 'cancel_join_thread' can work on a pool, 'result' would appear compatible type-wise (as in the pytorch code for worker it was applied on data_queue), but not even sure if it makes any sense (plus initially outside of the loop, so probably not meant for 'result').

@cyizhuo
Copy link

cyizhuo commented Apr 26, 2020

Don't know if it helps or not, but I created conda env with:

conda install scipy==1.0.0 (must be installed first)
conda install pytorch==1.2.0 torchvision==0.4.0 cudatoolkit=10.0 -c pytorch

and Net-Dissection-Lite worked perfect (on linux, never successed on windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants