Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CommandLineReporter #253

Open
7 tasks
AnakinRaW opened this issue May 25, 2020 · 0 comments
Open
7 tasks

Refactor CommandLineReporter #253

AnakinRaW opened this issue May 25, 2020 · 0 comments
Assignees

Comments

@AnakinRaW
Copy link
Collaborator

Currently the class IMO has a weak API design:

  • Add a constructor overload that only gets a collection (no list required) of rules.
  • Add a constructor that gets a File object, which must not be null. Throw when null.
  • For compatibility reasons keep the string, List constructor (change to Collection maybe) but mark it deprecated.
  • Internally the class holds an Optional<File>
  • Discuss whether the File input must be a File, Directory or any of both.
    • Implement behavior where necessary.
  • Create JavaDoc for all constructors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants