Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Collection<CryptSLRule> where possible #204

Open
5 tasks
AnakinRaW opened this issue Nov 15, 2019 · 0 comments
Open
5 tasks

Return Collection<CryptSLRule> where possible #204

AnakinRaW opened this issue Nov 15, 2019 · 0 comments

Comments

@AnakinRaW
Copy link
Collaborator

Motivation:
Currently most code (unnecessarily) returns a List<CryptSLRule>. Using the more generic type Collection would allow us to use List but also unsorted collections like HashSet simultaneously.

Tasks:

  • Discuss whether a forced sorted collection (List) is essential or could be substituted with a Collection
  • Discuss about other code where this might also occur.

If approved:

  • Perform code change everywhere appropriated.
  • As this is a major API change and will cause incompatibility change the minor version digit of the version number.
  • Apply changes to the IDE plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant