Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read DF_* parameters in Serpent-2.2.1 #490

Open
travleev opened this issue Aug 2, 2023 · 1 comment
Open

Read DF_* parameters in Serpent-2.2.1 #490

travleev opened this issue Aug 2, 2023 · 1 comment
Labels

Comments

@travleev
Copy link
Contributor

travleev commented Aug 2, 2023

Summary of issue

Serpent-2.2.1 prints additional ADF-related parameters to the results file *_res.m: DF_SURFACE_N_PARAM and DF_SURFACE_PARAMS. They do not follow the standard form (an array of value-error pairs), therefore their names must be specified in the parser. The following changes to the module serpentTools/parsers/results.py seem to solve the issue:

@@ -101,6 +101,7 @@ DF_CONV = {
         "DF_SYM",
         "DF_N_SURF",
         "DF_N_CORN",
+        "DF_SURFACE_N_PARAM"
     },
     # No uncertainty, convert to float
     float: {
@@ -110,6 +111,7 @@ DF_CONV = {
     str2vec: {
         "DF_SURF_AREA",
         "DF_MID_AREA",
+        "DF_SURFACE_PARAMS",
         "DF_CORN_AREA,",
         'MICRO_NG',
         'MICRO_E',

Versions

Please provide the following:

  • Version from serpentTools.__version__: "0.10.0.dev0"
  • Python version - python --version: Python 3.8.17
  • IPython or Jupyter version if applicable
  • If using the development version, the output from git describe: 0.9.4rc0-21-gc88cb67
@travleev travleev added the bug label Aug 2, 2023
@drewejohnson
Copy link
Collaborator

Thanks for this @travleev. Can you clarify something for me. Are these variables

  1. not included in the parser at all,
  2. included but in the wrong structure, or
  3. causing the parsing to fail entirely?

And if code change you provided fixes your issue, please feel free to make a branch off main, apply the change, and submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants