Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Forward more arguments to MPL plot routines #417

Open
2 of 3 tasks
drewejohnson opened this issue Aug 27, 2020 · 0 comments
Open
2 of 3 tasks

ENH Forward more arguments to MPL plot routines #417

drewejohnson opened this issue Aug 27, 2020 · 0 comments
Labels
API - Compatible Changes to our API that require no user actions enhancement good first issue
Projects

Comments

@drewejohnson
Copy link
Collaborator

drewejohnson commented Aug 27, 2020

A handful of our plot routines don't allow the user to pass on additional arguments to the underlying plot call, making configuration and tweaking a little frustrating. I'll highlight some here in no particular order that I think we should allow. Basically it would boil down to allowing **kwargs in the method signature, and then sending those directly to ax.plot or ax.errorbar, depending on how the plot is drawn.

@drewejohnson drewejohnson added enhancement good first issue API - Compatible Changes to our API that require no user actions labels Aug 27, 2020
@drewejohnson drewejohnson added this to the 0.10.0 milestone Aug 27, 2020
@drewejohnson drewejohnson added this to To do in Main Aug 27, 2020
@drewejohnson drewejohnson modified the milestones: 0.10.0, 0.9.4 Oct 6, 2020
@drewejohnson drewejohnson moved this from To do to In progress in Main Dec 17, 2020
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this issue Mar 22, 2021
Closes CORE-GATECH-GROUP#423

Default drawstyle is steps-post

Related to
- CORE-GATECH-GROUP#433 - relying on `drawstyle` over `steps`
- CORE-GATECH-GROUP#417 - passing more kwargs to matplotlib plot routines
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this issue Apr 15, 2021
Passing label is not allowed since we label based on dictionary values
passed for y and right quantities.

Closes CORE-GATECH-GROUP#422

Related to CORE-GATECH-GROUP#433 and CORE-GATECH-GROUP#417
@drewejohnson drewejohnson removed this from the 0.9.4 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Compatible Changes to our API that require no user actions enhancement good first issue
Projects
Main
In progress
Development

No branches or pull requests

1 participant