Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong code on NPM for 7.0.7 release #2774

Open
hundt-corbalt opened this issue Oct 31, 2023 · 1 comment
Open

Wrong code on NPM for 7.0.7 release #2774

hundt-corbalt opened this issue Oct 31, 2023 · 1 comment

Comments

@hundt-corbalt
Copy link

I updated to 7.0.7 to get this commit. If you look at

https://github.com/CMSgov/design-system/blob/%40cmsgov/design-system%407.0.7/packages/design-system/src/components/Tabs/TabPanel.tsx

You can see the commit applied:

image

But the actual code uploaded to NPM does not seem to include this commit:

https://www.npmjs.com/package/@cmsgov/design-system/v/7.0.7?activeTab=code

image
@pwolfert
Copy link
Collaborator

pwolfert commented Nov 7, 2023

@hundt-corbalt, it's strange that that commit is showing up under the @cmsgov/design-system@7.0.7 tag, and I still haven't figured out why. We didn't release it until v8.0.0. I think something went wrong with our release tagging, because our intention wasn't to release it until 8.0.0.

It's also curious how the commit is in the history of that tagged release commit, and yet our publishing infrastructure that checks out a specific tag didn't publish code with that commit to npm. I can see in the 7.0.7 publishing logs that @cmsgov/design-system@7.0.7 was checked out. If I check out that tag locally, I see the tab commit in the commit log. If I check out the commit that our publish job was on after it checked out that tag, the tab commit is not in the commit log. So at this point I'm not sure if it's a bug in our publish job, a bug in our release script that tags the commit, or GitHub modifying tags.

Thanks for bringing that to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants