Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiple masking config #91

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: multiple masking config #91

wants to merge 5 commits into from

Conversation

P0labrD
Copy link
Collaborator

@P0labrD P0labrD commented Mar 1, 2022

Close #23.

Note: this is a draft request; the question of the seed can be discussed:

  • keep the coherence between files: if both files has the same seeding, the global config should have the same seeding
  • generate a new seeding: global seed = seed1 + seed2 ( or another operation)

Less important: the version (in my understanding, the version field is not used in the pipeline, it's just useful for the user to keep track of the version of his files)

adrienaury
adrienaury requested changes Mar 1, 2022
View reviewed changes
pkg/model/pipeline.go Outdated Show resolved Hide resolved
@P0labrD
Copy link
Collaborator Author

P0labrD commented Mar 2, 2022

PR #92 might help for the problem of seeding.
It needs to be discussed.

@adrienaury adrienaury changed the title Proposal multiple masking config feat: multiple masking config May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienaury adrienaury adrienaury requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Pass multiple masking config to the command line
2 participants
@P0labrD @adrienaury