New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xsmm - update for function name change #1464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to identify the version? It seems like only the patch version has changed, like libxsmm main
is now at 1.17-3708
, and I assume 1.18
is next? Is there a better way?
I think I contributed a macro to them like ours. I think we need to ask them if a release is coming soon and then we can add a macro to that tensor file that uses their version marco |
I believe v2.0 is next and that's what they are preparing for. |
libXSMM should be making a new release in roughly 2-3 months time |
36bf1da
to
85fdfdc
Compare
85fdfdc
to
629f6fa
Compare
de7ab86
to
4441641
Compare
4441641
to
ed721ed
Compare
The LIBXSMM release is taking a while. What about merging this fix now since we're already requiring a min version that isn't the latest release. Then we can switch the min version to the next LIBXSMM release when it happens |
I agree with that. In Palace we are just applying the changes from this PR as a patch for all LIBXSMM builds (https://github.com/awslabs/palace/blob/main/extern/patch/libCEED/patch_xsmm.diff). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but we should document the min version somewhere more than CI, as this bleeding edge non-release version may be surprising to users.
This is true. Spack builds will fail by default too unless the user builds with |
This branch fixes #1462
It turns out it was just a name change. We can merge once libXSMM releases their new version, or sooner if needed.