Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluids naming consistency #1417

Open
jrwrigh opened this issue Dec 6, 2023 · 1 comment
Open

Fluids naming consistency #1417

jrwrigh opened this issue Dec 6, 2023 · 1 comment
Labels
examples

Comments

@jrwrigh
Copy link
Collaborator

jrwrigh commented Dec 6, 2023

(More to be added as I find them, just making one central location for them so I don't forget).

  • Use qfctx for CeedQFunctionContext objects, and ctx for the structs themselves
    • The inconsistent format is to use context for CeedQFunctionContext and ctx for the structs
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Mar 6, 2024

Another misc task: Move the comments describing functions in navierstokes.h into docstrings in the function. Doesn't make much sense to have them in the header file, especially when their redundant to the name of the function (yay for good function names though!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrwrigh