Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Date" is a reserved word in SQL and should not be used for field names #13

Open
aemnathanclinton opened this issue Jan 23, 2020 · 1 comment

Comments

@aemnathanclinton
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.
The following tables contain a field named "Date."

OrganizationFinancial
LearningResourcePeerRating
RoleAttendanceEvent

Expected behavior
A clear and concise description of what you expected to happen.
We should not use reserved words in our table structure. We should instead use the CEDS technical name.

Additional context
Add any other context about the problem here.

Here are the mappings to from the CEDS IDS "Date" fields mapped to the appropriate CEDS Technical Name, which should be used as the new field name.

OrganizationFinancial.Date = FinancialAccountingDate
LearningResourcePeerRating.Date = PeerRatingDate
RoleAttendanceEvent.Date = AttendanceEventDate

@EricMarshallNC
Copy link

There is another incident of this in the 'GoalPerformance' table. What would be the recommended new field name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants