Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when using the transforms bindings with reweighting #1

Open
bensarthou opened this issue May 7, 2018 · 1 comment
Open
Labels
bug Something isn't working

Comments

@bensarthou
Copy link

In the Condat-Vu reconstruction algorithm (for example in the reconstruct plugin), the options of reweighting "primal" and "dual" lead to some errors:

  • With "primal", it calls a method not defined in gradient method and crashes.

  • With "dual", if you use the wrapper to call the transforms, in some specific cases (transforms with nb_bands > 1), it applies wrongly the linear operator and the result of the reconstruction is deteriorated.

I haven't find a fix yet, as reweighting is out of my understanding.
For now, Sylvain has removed it in his PR factory, as it isn't used by anyone.

@bensarthou bensarthou changed the title Problems by using the transforms bindings with reweighting Problems when using the transforms bindings with reweighting May 7, 2018
@AGrigis AGrigis transferred this issue from CEA-COSMIC/pysap Mar 21, 2019
@zaccharieramzi zaccharieramzi added the bug Something isn't working label Jun 5, 2019
@chaithyagr
Copy link
Contributor

Also noting other issues here:

  1. The "dual" reweighting uses linear_op.transform object to obtain reweighting factor for each band, this is not scalable for all cases, especially for undecimated wavelet which I implemented for issue #4 .
  2. Both reweightings are incompatible for multichannel cases. Both would ideally have different reweighting per channel per band.

I am getting these fixes with a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants