Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the submission/delivery code #14350

Open
2 tasks
mkalish opened this issue May 9, 2024 · 3 comments
Open
2 tasks

Clean up the submission/delivery code #14350

mkalish opened this issue May 9, 2024 · 3 comments
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality

Comments

@mkalish
Copy link
Collaborator

mkalish commented May 9, 2024

User Story

As a RS developer, I would like the delivery submission endpoints to work effectively and to be well tested

Description/Use Case

The code for these endpoints is brittle and does not support easily iterating on the pipeline. Since the report lineage is agnostic of the steps the code should be able to be refactored to not need to specifically pull date out of the specifically named steps.

Risks/Impacts/Considerations

  • The endpoints no longer working as expected; however the understanding is that they are rarely used so the risk is low

Dev Notes

  • The recursive query can likely be replaced in favor the new report graph code

The problem code is below. The issue is that the route steps are hardcoded rather than being flexible to support arbitrary steps

descendants.filter { it.actionName == TaskAction.translate }.forEach { descendant ->
                enrichWithTranslateAction(descendant)
            }
            descendants.filter { it.actionName == TaskAction.route }.forEach { descendant ->
                enrichWithRouteAction(descendant)
            }
            descendants.filter { it.actionName == TaskAction.convert }.forEach { descendant ->
                enrichWithConvertAction(descendant)
            }

Acceptance Criteria

  • The delivery/submission endpoints are flexible enough to support any adjustments to the UP steps without having to be amended
  • Database tests are written to cover the functionality
@mkalish mkalish added platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality labels May 9, 2024
@arnejduranovic arnejduranovic added the ready-for-grooming Ticket is a point where we can productively discuss it label May 13, 2024
@Andrey-Glazkv
Copy link
Collaborator

@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @JFisk42

@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @david-navapbc

@Andrey-Glazkv Andrey-Glazkv removed the ready-for-grooming Ticket is a point where we can productively discuss it label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
Development

No branches or pull requests

3 participants