Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mars OTC ELR scenarios to E2E UP Test #14360

Merged
merged 6 commits into from May 15, 2024

Conversation

JFisk42
Copy link
Collaborator

@JFisk42 JFisk42 commented May 10, 2024

This PR adds end 2 end testing scenarios for Mars OTC ELR reports moving through the UP.
These scenarios test when reports with the Mars OTC ELR topic

  • Are sent in HL7 and received as HL7 and FHIR.
  • Are sent in FHIR and received as FHIR.
  • When invalid HL7 items are present in the report, these are filtered out.

Test Steps:

  1. Run ./gradlew testend2endup
  2. Verify that all scenarios pass.
    1. For scenario "Sending HL7 Report, Receiving HL7/FHIR (mars-otc-elr); Invalid HL7 Items Filtered Out":
      • A FHIR report should be sent to MARS_OTC_ELR_FHIR_B_E2E
      • An HL7 report should be sent to MARS_OTC_ELR
      • Both sent reports consist only of one item
      • One item has been filtered out with the message "Item 1 in the report was not valid. Reason: HL7 was not valid at OBX[1]-19[1].1"
    2. For scenario "Sending FHIR Report, Receiving FHIR (mars-otc-elr)":
      • A FHIR report should be sent to MARS_OTC_ELR_FHIR_A_E2E

Changes

  • Added two MARS OTC ELR scenarios in the UP end to end test
  • Modified test logging in a few places
  • Added MARS OTC ELR Senders/Receivers

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?

Linked Issues

@JFisk42 JFisk42 added the platform Platform Team label May 13, 2024
@JFisk42 JFisk42 force-pushed the platform/josh/14336-mars-otc-elr-e2e-test branch 2 times, most recently from e02a325 to 6d526cd Compare May 13, 2024 22:36
Copy link

github-actions bot commented May 13, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented May 13, 2024

Test Results

1 172 tests  ±0   1 168 ✅ ±0   7m 0s ⏱️ -6s
  147 suites ±0       4 💤 ±0 
  147 files   ±0       0 ❌ ±0 

Results for commit 4551890. ± Comparison against base commit 2122c04.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

Integration Test Results

 62 files  ±0   62 suites  ±0   33m 19s ⏱️ -3s
394 tests ±0  384 ✅ ±0  10 💤 ±0  0 ❌ ±0 
397 runs  ±0  387 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 4551890. ± Comparison against base commit 2122c04.

♻️ This comment has been updated with latest results.

@JFisk42 JFisk42 force-pushed the platform/josh/14336-mars-otc-elr-e2e-test branch from 6d526cd to 6aa898d Compare May 14, 2024 17:49
@JFisk42 JFisk42 force-pushed the platform/josh/14336-mars-otc-elr-e2e-test branch from 6aa898d to 72beed7 Compare May 14, 2024 18:11
@JFisk42 JFisk42 marked this pull request as ready for review May 14, 2024 18:13
@JFisk42 JFisk42 requested a review from a team as a code owner May 14, 2024 18:13
@mkalish mkalish self-assigned this May 14, 2024
Copy link
Collaborator

@mkalish mkalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! I confirmed that the tests pass and I was able to find the action log about the invalid item getting filtered.

Also, hadn't quite processed how much faster the end2end_up tests are, wow!

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JFisk42 JFisk42 merged commit 06e5df5 into master May 15, 2024
16 checks passed
@JFisk42 JFisk42 deleted the platform/josh/14336-mars-otc-elr-e2e-test branch May 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
Development

Successfully merging this pull request may close these issues.

Add MARS_OTC_ELR to the end2end UP test
2 participants