Thank you for your interest in contributing to the PRIME ReportStream project (aka Data Hub)! The PRIME ReportStream is an open-source project that is part of many PRIME projects which in turn are part of many open-source projects at the CDC. We love to receive contributions from our community — you! There are many ways to contribute, from writing tutorials or blog posts, improving the documentation, submitting bug reports and feature requests, or writing code for PRIME itself.
Before contributing, we encourage you to also read or LICENSE, README, and code-of-conduct files, also found in this repository. If you have any inquiries or questions not answered by the content of this repository, feel free to contact us.
This project is in the public domain within the United States, and copyright and related rights in the work worldwide are waived through the CC0 1.0 Universal public domain dedication. All contributions to this project will be released under the CC0 dedication. By submitting a pull request or issue, you are agreeing to comply with this waiver of copyright interest and acknowledge that you have no expectation of payment, unless pursuant to an existing contract or agreement.
If you think you have found a bug in the ReportStream, search our issues list on GitHub in case a similar issue has already been opened.
It is very helpful if you can prepare a reproduction of the bug. In other words, provide a small test case which we can run to confirm your bug. It makes it easier to find the problem and to fix it.
If you find yourself wishing for a feature that exists in the PRIME ReportStream, you are probably not alone.
Open an issue on our issues list on GitHub, which describes the feature you would like to see, why you need it, and how it should work.
If you would like to contribute a new feature or a bug fix to PRIME, please discuss your idea first on the Github issue. If there is no Github issue for your idea, please open one. It may be that somebody is already working on it or that there are particular complexities that you should know about before starting the implementation. There are often several ways to fix a problem, and it is essential to find the right approach before spending time on a PR that cannot be merged.
We use the good first issue label to mark the problems we think will be suitable for new contributors.
You will need to fork the main code or documentation repository and clone it to your local machine. See github help page for help.
Create a branch for your work. Since we are a small team, we consider a branch to have one owner, so force-push on a branch is ok. If a you need to base your work on someone elses branch, talk to the branch owner and work something out.
There are a couple engineering overview documents that need to be written. Please read them when they are written.
We want to emphasize some tried and true coding principles. A piece of code is read much more than times than it is written. Hence, we want readable code. Keep code functions short and at a single level of abstractions. Choose meaningful names and labels. Comments are welcomed, but only if the information provided cannot be expressed in code. Consider if refactoring with understandable names would be a better approach.
Our codebase is based on Kotlin because it is a multiplatform language with seamless JVM compatibility. We also like that Kotlin promotes type safety and nullability checks. Accordingly, we try to follow the Kotlin coding conventions. We reformat files to follow the style guide formatting rules as implemented by the ktlint tool. We emphasize the preferred Idioms of Kotlin which are based on the ideas of functional programming with immutable data.
Once your changes and tests are ready to submit for review:
-
Test your changes
Run the test suite to make sure that nothing is broken. These tests include
-
Rebase your changes
Update your local repository with the most recent code from the principal repository, and rebase your branch on top of the latest master branch. We prefer your initial changes to be squashed into a single commit. Later, if we ask you to make changes, add the changes as separate commits. This makes the changes easier to review.
-
Submit a pull request
Push your local changes to your forked copy of the repository and submit a pull request. In the pull request, please follow the PR template provided.
All PRs must have at least one approval. For complicated or large changes, consider asking for two approvals.
Note that squashing at the end of the review process should not be done. Rather, it should be done when the pull request is integrated via GitHub.
A good code review considers many aspects of the PR
- Will the code work and will it work in the long-term?
- Is the code understandable and readable? Is documentation needed?
- What are the security implications of the PR?
- Does the PR contain sensitive information like secret keys or passwords? Can these be logged?
Submitters should help reviewers by calling out how these responsibilities are met in comments on the review.
This document is a mashup of CDC's contributors and ElastiSearch's contributors document.