Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle the poetry.lock file (should we include it?) #88

Open
gvegayon opened this issue Apr 22, 2024 · 1 comment
Open

How to handle the poetry.lock file (should we include it?) #88

gvegayon opened this issue Apr 22, 2024 · 1 comment

Comments

@gvegayon
Copy link
Member

gvegayon commented Apr 22, 2024

I wonder if poetry.lock should always change with PRs? Or better yet, shouldn't the pyproject.toml file be the only thing to distribute with the repo? poetry doesn't have a black/white stance on it. I think poetry.lock should only be distributed for development, but not for other users, furthermore, perhaps we should only have poetry.lock for the actual pipeline implementation (not the pipeline package).

What do you think @AFg6K7h4fhy2 @dylanhmorris @natemcintosh @zsusswein?

Originally posted by @gvegayon in #86 (comment)

@gvegayon gvegayon added this to the Backlog milestone Apr 22, 2024
@natemcintosh
Copy link
Collaborator

I think using the poetry.lock for deploying the code would be good. I am ambivalent about keeping it otherwise

@damonbayer damonbayer modified the milestones: Backlog, K Sprint May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants