Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Continuous Integration for macOS and Windows #120

Open
damonbayer opened this issue May 14, 2024 · 2 comments
Open

Extend Continuous Integration for macOS and Windows #120

damonbayer opened this issue May 14, 2024 · 2 comments

Comments

@damonbayer
Copy link
Collaborator

Goal

If we want make PyRenew widely usable, we should extend our CI to run across multiple platforms and ensure that our code works as expected.

Context

While working through our tutorials on macOS, I found that model/docs/example-with-datasets.qmd cannot be rendered on macOS because jnp.abs(1 - jnp.sum(inf_hosp_int)) $\approx$ 1e-07 > 1e-20, which causes inf_hosp_int = deterministic.DeterministicPMF(inf_hosp_int) to error.
This error does not occur in linux.

@gvegayon gvegayon added this to the Backlog milestone May 14, 2024
@gvegayon
Copy link
Member

Adding this to the backlog, @damonbayer.

@damonbayer
Copy link
Collaborator Author

This is done in EpiAware: https://github.com/CDCgov/Rt-without-renewal/blob/919b8a8cd40ef116a3004b60720ab33d85091b6c/.github/workflows/test-EpiAware.yaml#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants