Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Modelnet2048 using PyG InMemoryDataset #17

Open
CCInc opened this issue Nov 18, 2022 · 6 comments
Open

Rewrite Modelnet2048 using PyG InMemoryDataset #17

CCInc opened this issue Nov 18, 2022 · 6 comments
Assignees

Comments

@CCInc
Copy link
Owner

CCInc commented Nov 18, 2022

Currently, custom code is written to handle the downloading/processing of modelnet2048. It should be rewritten in the context of a pytorch geometric InMemoryDataset, which has helper functions to handle downloading and processing of the data from the h5py input format (and removing the custom implemented download functions)

See:
https://pytorch-geometric.readthedocs.io/en/latest/notes/create_dataset.html
https://github.com/pyg-team/pytorch_geometric/blob/master/torch_geometric/datasets/s3dis.py <- the pyg s3dis dataset also comes from a h5py source, very similar to modelnet2048

@CCInc
Copy link
Owner Author

CCInc commented Nov 18, 2022

@Stakhan mind taking a look at this?

@Stakhan
Copy link
Collaborator

Stakhan commented Nov 18, 2022

Sure!

@Stakhan Stakhan self-assigned this Nov 18, 2022
@Stakhan
Copy link
Collaborator

Stakhan commented Nov 18, 2022

I'm a bit confused with the name. From the dataset webpage it seems that there is only:

  • ModelNet10
  • ModelNet40

Isn't it in fact ModelNet40?

@CCInc
Copy link
Owner Author

CCInc commented Nov 18, 2022

This is "ModelNet40", but it's a presampled version that has 2048 points per sample (more commonly found on point cloud tasks). This is in contrast to the original ModelNet40, which are CAD models (i.e. they need to have their surfaces sampled before running them through a point cloud task).

@Stakhan
Copy link
Collaborator

Stakhan commented Nov 18, 2022

Okay. Thank you for the clarification.

@CCInc
Copy link
Owner Author

CCInc commented Nov 18, 2022

It will be good to document all of this at some point for each dataset, since there are many different versions used by different papers. it can be quite confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants