Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Negative -delay values produce empty .srt output #1389

Closed
muzicman0 opened this issue Nov 7, 2021 · 5 comments
Closed

[BUG] Negative -delay values produce empty .srt output #1389

muzicman0 opened this issue Nov 7, 2021 · 5 comments

Comments

@muzicman0
Copy link

CCExtractor version: 0.93

Necessary information

  • Is this a regression (i.e. did it work before)? YES (worked 0.88, does not work on 0.93)
  • What platform did you use? Windows
  • What were the used arguments? -delay -10000

Video links

https://1drv.ms/u/s!AmIBKnKiJ1bih7QqG_PJfxvirnnV5g?e=bXHJe2

link above, but any of my recorded TV files have the same issue.

Additional information

Negative -delay option on (at least) the CLI doesn't work (empty .srt file). It did work on version 0.88. I recently updated to the latest version (0.93) and it no longer works. tried multiple files, and multiple negative values.

Positive delay options work fine (IE: -delay 1000)

@PunitLodha
Copy link
Member

This was fixed recently. You can try compiling the code from the master branch

@cfsmp3 cfsmp3 closed this as completed Nov 20, 2021
@muzicman0
Copy link
Author

Thanks. I saw that it had been fixed. Compiling is probably beyond me right now, so I will just wait for now.

@muzicman0
Copy link
Author

.94 is up, so I am checking it out to make sure it works for me. Thanks!

@muzicman0
Copy link
Author

I guess I will just stick with the old version. .94 doesn't work on some files at all, and only pulls a few minutes of captions on others.

@PunitLodha
Copy link
Member

PunitLodha commented Dec 17, 2021

This could be a bug. Could you create a new issue for it? With details about which files aren't working.

Also, there was a change in the flags. In 0.94 :-

  • if no params are provided:- extract whatever is available, if both(708 and 608) are available then extract both
  • If -1/-2 is provided:- extract only 608 subs
  • if -svc is provided:- extract only 708 subs
  • if both -1/-2 and -svc are provided:- extract both 608 and 708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants