Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency upgrade progress #1390

Open
mschachter opened this issue Dec 12, 2020 · 3 comments
Open

dependency upgrade progress #1390

mschachter opened this issue Dec 12, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@mschachter
Copy link

Hi, just wanted to give an update on the process of upgrading dependencies. On this branch I have all the cmake files and many small issues in the source code corrected so that CaPTk starts to build for:

  • Eigen 3.3.8
  • ITK 5.1.2
  • VTK 9.0.1
  • OpenCV 4.5.0

Things were going ok until I encountered build issues with the greedy package (in src/applications/Preprocessing). This package seems to be forked - why is that?

I started upgrading dependencies to greedy on a forked branch, but paused because some of the threading code needs to be refactored and want some input from the maintainer before diving into it.

Let me know what you think if you get the chance!

@sarthakpati
Copy link
Contributor

sarthakpati commented Dec 14, 2020

This package seems to be forked - why is that?

Looking at the diff with the main repo, it seems to have an integrated CMake build system and an extra CLI wrapper that makes working with greedy a bit easier.

I started upgrading dependencies to greedy on a forked branch, but paused because some of the threading code needs to be refactored and want some input from the maintainer before diving into it.

That sounds great! I am hopeful that Paul would be able to resolve the questions you have.

@sarthakpati
Copy link
Contributor

Paul has updated Greedy to support ITK-5 in a new branch: https://github.com/pyushkevich/greedy/tree/itk5

@sarthakpati sarthakpati added the enhancement New feature or request label Jan 13, 2021
@mschachter
Copy link
Author

Noted - I'll return to this project as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants