Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core dump on failure to open file #9

Open
bhuffaker opened this issue Sep 10, 2018 · 1 comment
Open

core dump on failure to open file #9

bhuffaker opened this issue Sep 10, 2018 · 1 comment
Labels

Comments

@bhuffaker
Copy link
Member

ipmeta_provider_netacq_edge_init: failed to open location file '/data/external/netacuity-dumps/Edge-processed/2018-08-03.netacq-4-locations.csv.gz'
python2: ipmeta.c:160: ipmeta_lookup: Assertion `provider != ((void *)0) && provider->enabled != 0' failed.
Aborted (core dumped)

@bhuffaker bhuffaker added the bug label Sep 10, 2018
@alistairking
Copy link
Member

It's a programming error to try and do a lookup on a provider that failed to enable (i.e., this assert can only fire with incorrect code).
Since the lookup function is on the critical path for high-performance lookups, I'd actually be inclined to remove this assert altogether and let it fail in some other way.

But yeah, this is a little unfriendly when using the python bindings. Probably the best place to fix this is in pyipmeta since that will (should) never be used for super performance critical lookups (e.g., in traffic trace processing).

@alistairking alistairking added wontfix and removed bug labels Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants