Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbiosis-configure-ips doesn't remove IPs it added once they are removed from /srv/*/config/ip #59

Open
patch0 opened this issue Jun 13, 2017 · 2 comments
Assignees

Comments

@patch0
Copy link
Contributor

patch0 commented Jun 13, 2017

If an IP has been added to a machine via /srv/*/config/ip, then if removed, it won't be removed from the configuration until next reboot when it won't be re-added.

This is likely as it can't be determined that Symbiosis added the IP, so we should probably either:

  1. Make it clear in the docs that removing an IP will need a reboot or manual change via ip.
  2. Automatically remove any IPs not set somewhere in /srv/*/config/ip when running symbiosis-configure-ips.
  3. Provide a --force switch (like the other Symbiosis apps) to make the config match what symbiosis-configure-ips is trying to do.

Originally reported on Bytemark's Gitlab by @pcammish on 2017-05-02T11:03:24.561Z

@patch0
Copy link
Contributor Author

patch0 commented Jun 13, 2017

This logic would remove IPs that the user has configured in /etc/network/interfaces so we'd need to think carefully here :)

Originally posted by @patch0 on 2017-05-10T20:44:00.248Z

@patch0
Copy link
Contributor Author

patch0 commented Jul 7, 2017

At the moment IPs are added, and no state is kept when things are added/removed. A --force flag could do the trick, but we'd want to be careful not to remove the "main" IP :)

@patch0 patch0 self-assigned this Jul 7, 2017
@patch0 patch0 added the bug label Jul 20, 2017
@patch0 patch0 modified the milestone: buster+ Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant