Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: postinst needs to check for a better valid hostname #57

Closed
patch0 opened this issue Jun 13, 2017 · 3 comments
Closed

common: postinst needs to check for a better valid hostname #57

patch0 opened this issue Jun 13, 2017 · 3 comments
Assignees
Labels

Comments

@patch0
Copy link
Contributor

patch0 commented Jun 13, 2017

The HOSTNAME env variable doesn't tend to bell

It should probably check against a regexp for the presence of a dot in the $HOSTNAME env variable:

/^[_a-z0-9-]+\.([_a-z0-9-]+\.?)+$/

would do the trick

Originally reported on Bytemark's Gitlab by @patch0 on 2017-04-21T19:29:30.820Z

@patch0
Copy link
Contributor Author

patch0 commented Jul 7, 2017

I think this was following testing inside docker containers, where HOSTNAME gets set weirdly, and really shouldn't be used.

@patch0 patch0 added the bug label Jul 10, 2017
@patch0 patch0 added this to the stretch release milestone Jul 20, 2017
@telyn
Copy link
Contributor

telyn commented Jul 24, 2017

it's causing similar problems with systemd containers i think

@telyn
Copy link
Contributor

telyn commented Aug 10, 2017

Is this bug meant to fix-up invalid $HOSTNAMEs by appending '.localdomain', or just complain early in the install process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants