Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Description for "Ghosts of the Deep" Dungeon in Weekly Rotating Challenges #1871

Open
Devdoot-Maji opened this issue Jan 10, 2024 · 0 comments

Comments

@Devdoot-Maji
Copy link

The current description for the milestone with milestoneHash of 390471874 in the "Get Milestone Definition for Id" API response is "Weekly Dungeon Challenge." However, with the introduction of new dungeon (Warlord's Ruin) this season, the "Ghosts of the Deep" dungeon has moved into the weekly rotating dungeon challenges. The correct description should be "Rotating Weekly Dungeon Challenge."

Steps to Reproduce:

  1. Call the "Get Public Milestones" API endpoint: {{apiRootPath}}/Destiny2/Milestones
  2. Find the milestone with milestoneHash of 390471874 in the response.
  3. Call the "Get Milestone Definition for Id" API endpoint: {{apiRootPath}}/Destiny2/Manifest/DestinyMilestoneDefinition/{{milestoneHash}}
  4. Observe the value of Response.displayProperties.description in the response.

Expected Result:

The description for the "Ghosts of the Deep" dungeon should be "Rotating Weekly Dungeon Challenge" to align with other rotating dungeons.

Actual Result:

The description is currently set as "Weekly Dungeon Challenge," which is incorrect.

{
    "Response": {
        "displayProperties": {
            "description": "Weekly Dungeon Challenge.",
            "name": "Ghosts of the Deep",
            "icon": "/common/destiny2_content/icons/DestinyMilestoneDefinition_7b2e832d6fa3513b3c3e55f69aaeee40.png",
            "hasIcon": true
        }
}

Additional Information:

This issue becomes evident when comparing it with other dungeons like the "Prophecy" dungeon, which has the correct description: "Rotating Weekly Dungeon Challenge."

{
    "Response": {
        "displayProperties": {
            "description": "Rotating Weekly Dungeon Challenge.",
            "name": "Prophecy",
            "icon": "/common/destiny2_content/icons/DestinyMilestoneDefinition_7b2e832d6fa3513b3c3e55f69aaeee40.png",
            "hasIcon": true
        }
}

Impact:

This issue affects the accuracy of the milestone description and may cause confusion among players regarding the nature of the weekly challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant