Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindly asking for DestinyProgressionDefinition entries representing Activity streaks be labeled and referenced as such ❤️ 🏷️ #1868

Open
rslifka opened this issue Dec 28, 2023 · 0 comments

Comments

@rslifka
Copy link

rslifka commented Dec 28, 2023

Situation

A handful of reputation/activities in the game have "streaks" related to them (i.e. how many of that activity you've played continuously).

  • Manifest: Streaks are represented as DestinyProgressionDefinition entries.
  • API: Streaks are represented as Response.characterProgressions.data.CHARACTER_ID.progressions.* when calling GetProfile?components=CharacterProgressions (202)

Complication(s)

The only way to identify a streak is by playing an activity and seeing which Progression has increased from 0-1-2, etc. The kind folks at DIM have documented this process.

  1. Reputation DestinyProgressionDefinitions have no streak DestinyProgressionDefinition reference, so it's unclear if a a reputation has an associated streak.
  2. Streak DestinyProgressionDefinitions have no reputation DestinyProgressionDefinition reference, so it's unclear which reputation a streak is... streaking? 🙈 😆
  3. Streak DestinyProgressionDefinitions are unlabeled, so it's unclear if it's a streak from looking at the entry independently.

Question

  1. Is it possible to have a pointer from reputation -> streak?
  2. Is it possible to have a pointer from streak -> reputation?
  3. Is it possible to have for the streaks themselves be labeled?

Example Suggestions

Take these with a grain of salt; I'm working to follow the pattern I believe is already present in the manifest/API 😄 🙏

Crucible Rank - DestinyProgressionDefinition (Abbreviated)

This is the existing Crucible Progression, with a field added indicating there is a streak associated with it.

{
  "displayProperties": {
    "displayUnitsName": "Crucible Rank Progress",
    "name": "Crucible Rank",
  }
  "factionHash": 697030790,
  "hash": 2083746873,
  "streakProgressionHash": 2203850209
}

Crucible Rank Streak - DestinyProgressionDefinition (Abbreviated)

This is the existing streak Progression, with its displayProperties partially filled in. To cut down on i18n work, the description isn't strictly necessary. I figure since the word "streak" already appears in-game, the i18n effort would be less.

There's also a new reputationProgressionHash to reference what this streak is streaking. I wasn't sure what to name this 😬

{
  "displayProperties": {
    "displayUnitsName": "Streak",
    "description": "Number of Crucible activities completed continuously",
    "name": "Crucible Activity Streak",
    "hasIcon": false
  },
  "steps": [ ],
  "hash": 2203850209,
  "reputationProgressionHash": 697030790
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant