Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The API's handling of uninstanced item perks doesn't seem to work #1860

Open
ChiriVulpes opened this issue Oct 14, 2023 · 0 comments
Open

The API's handling of uninstanced item perks doesn't seem to work #1860

ChiriVulpes opened this issue Oct 14, 2023 · 0 comments

Comments

@ChiriVulpes
Copy link

ChiriVulpes commented Oct 14, 2023

It breaks the companion app, too:

In-game:
image

Companion app:
image

Using data from these API fields:
1. perks from DestinyBaseItemComponentSetOfuint32 (both ProfileResponse and CharacterResponse)

  • Only ever seem to contain a couple perks from Root of Nightmares mods, which is weird because I have no Root of Nightmares mods equipped. It's also different ones per class that it shows, and I think these mods are unlocked globally?

2. uninstancedItemPerks from DestinyCharacterProgressionComponent

  • Always seems to be empty {}
const perkRefs = undefined
	// only applies to instanced items
	?? profile.itemComponents?.perks.data?.[itemInstanceId]?.perks
	// 1. `perks`
	?? (profile.characterUninstancedItemComponents && Object.values(profile.characterUninstancedItemComponents))
		?.find(uninstancedItemComponents => uninstancedItemComponents?.perks?.data?.[itemHash]?.perks)
		?.perks?.data?.[itemHash]?.perks
	// 2. `uninstancedItemPerks` 
	?? (profile.characterProgressions?.data && Object.values(profile.characterProgressions.data))
		?.find(progression => progression.uninstancedItemPerks[itemHash])
		?.uninstancedItemPerks[itemHash].perks;

For more example items that aren't working: Defiant Keys & Deep Dive Keys. Afaik the correct way to handle the perks is to hide them by default due to perkVisibility: 2, and in that case only show them if the perk reference has visible: true. But I can't get perk reference info for these ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant