Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote/local endpoint information into HTTP request routing handlers #125

Open
Alkenso opened this issue May 11, 2022 · 2 comments
Open

Comments

@Alkenso
Copy link

Alkenso commented May 11, 2022

In some situations it is very handy have the ability to get information about the client when processing the HTTP request

Please add forwarding of HTTPConnection's local/remote endpoints into HTTPRequest or handlers that handles requests

@Alkenso Alkenso changed the title Add remove/local endpoint information into HTTP request routing handlers Add remote/local endpoint information into HTTP request routing handlers Jun 24, 2022
@yvbeek
Copy link
Member

yvbeek commented Aug 13, 2022

Thanks, good suggestion 👍

This would require quite a bit of refactoring. Unfortunately I'm no longer using Telegraph in my day-to-day work, making it difficult to find time to make improvements to the library.

Probably the next big thing to do is to remove CocoaAsyncSocket and use the Networking library that Apple introduced with iOS 12. That will already have some impact on the classes that you've mentioned. During that refactor more of the internals could the exposed to provide more information in routes and handlers.

@Alkenso
Copy link
Author

Alkenso commented Aug 13, 2022

Thank for your response. I would be glad to hear one day that Telegraph got so incredible update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants