Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run dev "package.json invalid path" error caused by @builder.io/dev-tools #3045

Open
ijustwannacodetoday opened this issue Mar 7, 2024 · 3 comments
Assignees

Comments

@ijustwannacodetoday
Copy link

Hi, I just signed up for Builder, I’m on the “Welcome to Builder” screen, using “Integrate your existing project”.
I get an error when starting dev server - Error: Invalid path: C:\dev\project\code\package.json (7341) - when executing npm run dev on Windows.

Describe the bug
I created a new Qwik site using Cloudflare Pages integration following Deploy a Qwik site · Cloudflare Pages docs.
Then, I signed up at builder.io, and got to the “Welcome to Builder” screen, which said to run npm init builder.io@latest --existing to “Integrate your existing project”.
After that, I ran npm install and npm run dev, but it errors out right away with the following:

> dev
> vite --mode ssr

error when starting dev server:
Error: Invalid path: C:\dev\project\code\package.json (7341)
    at m (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/node/index.mjs:1:2907)
    at Object.readFile (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/node/index.mjs:1:1629)
    at f (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/node/index.mjs:1:466)
    at u (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/node/index.mjs:1:583)
    at $ (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/node/index.mjs:1:2704)
    at configureServer (file:///C:/dev/project/code/node_modules/@builder.io/dev-tools/vite/index.mjs:3:293)
    at _createServer (file:///C:/dev/project/code/node_modules/vite/dist/node/chunks/dep-jDlpJiMN.js:64550:30)
    at async CAC.<anonymous> (file:///C:/dev/project/code/node_modules/vite/dist/node/cli.js:762:24)

To Reproduce
Steps to reproduce the behavior on Windows:

  1. npm create cloudflare@latest my-qwik-app -- --framework=qwik
  2. npm init builder.io@latest --existing
  3. npm install
  4. npm run dev

Expected behavior
Qwik dev server working locally on a Windows machine after integrating Builder.

Additional context
These are the dependencies added:

    "@builder.io/dev-tools": "^0.2.19",
    "@builder.io/sdk-qwik": "^0.14.3"

And it fails here:

if(!o.startsWith(n))throw new Error(`Invalid path: ${o} (7341)`)

Debugging values:

n: 'C:/dev/project/code'
o: 'C:\dev\project\code\package.json'

The issue seems to stem from a non-normalized path separator.

Could anyone please help fix this?

@rbaekdev
Copy link

rbaekdev commented Mar 23, 2024

Solution 1:

A quick fix for you and anyone on Windows

Edit your /node_modules/@builder.io/dev-tools/vite/index.mjs file on line 3, character 293

// add .replaceAll("/", "\\") to t.config.root
async configureServer(t){let n=await $({getRootDir:()=>t.config.root.replaceAll("/", "\\")})

Solution 2:
A bit more typing
Edit your /node_modules/@builder.io/dev-tools/vite/index.mjs file

// import join from path at beginning of file
import { join } from 'path';
//... rest of file
// search for and edit -> configureServer(t)
async configureServer(t){let n=await $({getRootDir:()=>join(t.config.root)})
//... rest of file

@mrkoreye
Copy link
Collaborator

mrkoreye commented Apr 9, 2024

Thank you @rbaekdev for the workaround!

@akshays-repo
Copy link

how can I fix the issue with out editing the node modules ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants