Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oil tank + bucket in creative mode doesn't give an oil bucket #4696

Open
Pirulax opened this issue Feb 6, 2023 · 3 comments
Open

Oil tank + bucket in creative mode doesn't give an oil bucket #4696

Pirulax opened this issue Feb 6, 2023 · 3 comments
Labels
auto: bug This issue was based on the "bug" issue type, and hasn't been looked at yet.

Comments

@Pirulax
Copy link

Pirulax commented Feb 6, 2023

Please complete the following information:

  • Forge Version: 14.23.5.2847 (MC 1.12.2)
  • BuildCraft Version (Add Hash if from github): 7.99.24.7
  • Any additonal mods: None (Though, I'm using TCR Classic Refined from Technic, but I did test it with only BC, and the same thing occurs)

To Reproduce
Steps to reproduce the behavior:
0. Be in creative mode

  1. Place down a tank
  2. Fill it with oil (Using oil buckets, pump, doesn't matter)
  3. Take an empty bucket, right click the tank. The tank's oil level will be decreased, but you won't get an oil bucket in the inventory.
  4. Go to survival mode
  5. Try the same, and you'll get a bucket

Now, in itself it wouldn't be a big problem, you're in creative mode anyways. But, mods like ProjectRed's (Or OpenBlock's for that matter) "Block Placer" won't "suck up" the oil into buckets either.
I've looked at the code of PR's "Block Placer" and it uses a fake player entity, I'd assume that is what causes the issue.

@Pirulax Pirulax added the auto: bug This issue was based on the "bug" issue type, and hasn't been looked at yet. label Feb 6, 2023
@AlexIIL
Copy link
Member

AlexIIL commented Feb 7, 2023

Oil tank + bucket in creative mode doesn't give an oil bucket

That's fully intentional, and not a bug.

mods like ProjectRed's (Or OpenBlock's for that matter) "Block Placer" won't "suck up" the oil into buckets either.

This is a bug, but there's likely nothing we can do about it from buildcraft's side, since it just uses a simple "is the player in creative mode check".

@Pirulax
Copy link
Author

Pirulax commented Feb 7, 2023

Thanks for the answer.
I wonder what's the reasoning behind doing it like this?
I can't find the relevant code (Nor I have a lot of experience with MC modding), but I wonder if removing that check would solve the issue. Maybe (for whatever reason) the fake players are in creative mode.
I'll try compiling the code myself, maybe that'd (and removing the check) fix it.

@Primitive-Human
Copy link

Thanks for the answer. I wonder what's the reasoning behind doing it like this? I can't find the relevant code (Nor I have a lot of experience with MC modding), but I wonder if removing that check would solve the issue. Maybe (for whatever reason) the fake players are in creative mode. I'll try compiling the code myself, maybe that'd (and removing the check) fix it.

Mimicking vanilla bucket behavior: in creative mode, filled buckets can place fluids endless times and empty buckets clear fluids endless times.

If you really want to circumvent this; use a tank with a GUI for accepting fluid containers to fill/empty whatever fluid you want. Examples being the Forestry Bottler, IC2 Bottling station, EnderIO tanks, GTCE tanks and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto: bug This issue was based on the "bug" issue type, and hasn't been looked at yet.
Projects
None yet
Development

No branches or pull requests

3 participants