Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set scripts loading limit #55

Open
knassar702 opened this issue Nov 16, 2022 · 2 comments
Open

Set scripts loading limit #55

knassar702 opened this issue Nov 16, 2022 · 2 comments
Labels
core-changes make changes for Lotus Core in Rust

Comments

@knassar702
Copy link
Contributor

knassar702 commented Nov 16, 2022

There is a possibility to set a limit for loading and reading lua scripts, for example, by using the command --limit 5 (5 scripts per URL).

We can read five scripts for each url if we have 100 scripts; when the five scripts end, we can read five more scripts for that url.

@knassar702 knassar702 added the core-changes make changes for Lotus Core in Rust label Nov 16, 2022
@knassar702 knassar702 added this to the 0.0.5-beta milestone Nov 16, 2022
@knassar702 knassar702 modified the milestones: 0.0.5-beta, 0.0.4-beta Nov 28, 2022
@JettChenT
Copy link

Hi! I want to try working on this issue.

Can I assume the script loading limit would be implemented on the start function in src/lib.rs?

My current understanding is to add a parameter in this function, limit:Option<usize>, which limits the number of scripts that can be loaded simultaneously.

@knassar702
Copy link
Contributor Author

Thank you @JettChenT, yes, you should change the src/lib.rs file and add a new variable to the start function
The next step would be to move the reading function from line 70 to line 89 (within the scope of the stream) as the next step.

best regards
khaled

@knassar702 knassar702 modified the milestones: 0.0.4-beta, 0.0.5-beta Feb 14, 2023
@knassar702 knassar702 removed this from the 0.0.5-beta milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-changes make changes for Lotus Core in Rust
Projects
None yet
Development

No branches or pull requests

2 participants