Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS X M-series mac build failure #6

Open
truedat101 opened this issue Dec 22, 2023 · 2 comments
Open

Mac OS X M-series mac build failure #6

truedat101 opened this issue Dec 22, 2023 · 2 comments

Comments

@truedat101
Copy link

Compiler helped find the fix, rename hackstack to haystack. Probably your tests are on Windows so this gets missed in the ifdef.

[ 65%] Building CXX object CMakeFiles/BrotBoxEngine.dir/BrotBoxEngine/String.cpp.o
/Users/dkords/dev/repos/BrotBoxEngine/BrotBoxEngine/String.cpp:797:20: error: use of undeclared identifier 'hackstack'; did you mean 'haystack'?
        return strcasestr(hackstack, needle) != nullptr;
                          ^~~~~~~~~
                          haystack
/Users/dkords/dev/repos/BrotBoxEngine/BrotBoxEngine/String.cpp:792:52: note: 'haystack' declared here
static bool platformIndependentStrStrI(const char* haystack, const char* needle)
                                                   ^
1 error generated.
@Brotcrunsher
Copy link
Owner

Hi there! Thanks for the report. Sorry about the delay. This should have been fixed by now. I would be very happy if you could test it (works on Linux and Windows right now).

@truedat101
Copy link
Author

Thanks, I think your fix is ok, however, other issue:

/dir/BrotBoxEngine/Third-Party/openal-soft-1.23.0/common/alcomplex.h:4:10: fatal error: 'complex' file not found
#include <complex>
         ^~~~~~~~~
1 error generated.
make[2]: *** [Third-Party/openal-soft-1.23.0/CMakeFiles/OpenAL.dir/common/alcomplex.cpp.o] Error 1
make[1]: *** [Third-Party/openal-soft-1.23.0/CMakeFiles/OpenAL.dir/all] Error 2
make: *** [all] Error 2

https://en.cppreference.com/w/cpp/numeric/complex

this is too bleeding edge I think c++23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants